REFACTOR: support custom order by column #1668
Conversation
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1668 +/- ##
==========================================
+ Coverage 22.77% 22.85% +0.08%
==========================================
Files 622 621 -1
Lines 44809 44857 +48
==========================================
+ Hits 10204 10254 +50
+ Misses 33865 33851 -14
- Partials 740 752 +12
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
pkg/service/trade.go
Outdated
| @@ -304,11 +309,24 @@ func (s *TradeService) Query(options QueryTradesOptions) ([]types.Trade, error) | |||
| sel = sel.Where(sq.Eq{"exchange": options.Sessions}) | |||
| } | |||
|
|
|||
| orderByColumn := "traded_at" | |||
| if options.OrderByColumn != "" { | |||
| if options.OrderByColumn != "traded_at" && options.OrderByColumn != "gid" { | |||
There was a problem hiding this comment.
using switch case might be better here?
pkg/service/trade.go
Outdated
| sel = sel.OrderBy("traded_at " + options.Ordering) | ||
| } else { | ||
| sel = sel.OrderBy("traded_at ASC") | ||
| if options.Ordering != "ASC" && options.Ordering != "DESC" { |
ycdesu
force-pushed
the
yc/custom-orderby-column
branch
from
8a3ef17
to
bce68ff
Compare
ycdesu
force-pushed
the
yc/custom-orderby-column
branch
from
bce68ff
to
9fb273e
Compare
c9s
changed the title
|
Re-estimated karma: this pull request may get 297 BBG |
|
Hi @ycdesu, Well done! 302 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0x6c0ca1cfbdd7ee27e52a41f0cb41377dafe2302010f04960849a475df87dfdb8 Thank you for your contribution! |
Now user is able to specify the ordering column.