FEATURE: [xalign] add withdraw detection #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9s
requested review from
zenixls2,
ycdesu,
kbearXD,
gx578007,
narumiruna and
bailantaotao
|
Welcome back! @c9s, This pull request may get 414 BBG. |
|
Re-estimated karma: this pull request may get 435 BBG |
gx578007
approved these changes
Jul 31, 2024
| WithdrawStateConfirmed WithdrawState = "confirmed" | ||
| WithdrawStatePending WithdrawState = "pending" | ||
| WithdrawStateProcessing WithdrawState = "processing" | ||
| WithdrawStateCanceled WithdrawState = "canceled" |
There was a problem hiding this comment.
Is this keyword defined by Max because it lacks an "l" and is different from another definition below?
| @@ -391,6 +419,14 @@ func (s *Strategy) align(ctx context.Context, sessions map[string]*bbgo.Exchange | |||
| } | |||
| } | |||
|
|
|||
| foundActiveTransfer, err := s.detectActiveTransfers(ctx, sessions) | |||
| if err != nil { | |||
| log.WithError(err).Errorf("unable to check active transfers") | |||
There was a problem hiding this comment.
What do you think skipping aligning if any error happens?
|
Hi @c9s, Well done! 460 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0xfa8cf73ec2382103077c86164525dea6a7fd86d59897613680fa2f9625daa9dc Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.