FIX: types/stream: change errorf to warnf #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9s
requested review from
ycdesu,
kbearXD,
gx578007,
narumiruna and
bailantaotao
|
Welcome back! @c9s, This pull request may get 205 BBG. |
c9s
commented
Sep 12, 2024
| @@ -249,7 +249,7 @@ func (s *StandardStream) Read(ctx context.Context, conn *websocket.Conn, cancel | |||
|
|
|||
| default: | |||
| if err := conn.SetReadDeadline(time.Now().Add(readTimeout)); err != nil { | |||
| log.WithError(err).Errorf("set read deadline error: %s", err.Error()) | |||
| log.WithError(err).Errorf("unable to set read deadline: %v", err) | |||
c9s
commented
Sep 12, 2024
| @@ -352,7 +352,7 @@ func (s *StandardStream) ping( | |||
| } | |||
|
|
|||
| if err := conn.WriteControl(websocket.PingMessage, nil, time.Now().Add(writeTimeout)); err != nil { | |||
| log.WithError(err).Error("ping error", err) | |||
| log.WithError(err).Warnf("unable to write ws control message, ping error: %v", err) | |||
bailantaotao
approved these changes
Sep 12, 2024
ycdesu
approved these changes
Sep 12, 2024
gx578007
approved these changes
Sep 12, 2024
|
Hi @c9s, Well done! 230 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0x1a30938b2a85af20292ab2f2781080ee29f42afca64d23af2ab354d2abb8e0fd Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.