Update screenshots, fix charts button test and hide heatmaps buttons

cBioPortal · Feb 8, 2022 · 8076c17 · 8076c17
1 parent 7cdcce6
commit 8076c17
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 14 deletions.
diff --git a/...remote/screenshots/reference/filter_study_from_url_element_chrome_1600x1000.png b/...remote/screenshots/reference/filter_study_from_url_element_chrome_1600x1000.png
diff --git a/...ference/study_view_laml_tcga_clinical_data_clicked_element_chrome_1600x1000.png b/...ference/study_view_laml_tcga_clinical_data_clicked_element_chrome_1600x1000.png
diff --git a/...te/screenshots/reference/tcga_pancancer_atlas_page_element_chrome_1600x1000.png b/...te/screenshots/reference/tcga_pancancer_atlas_page_element_chrome_1600x1000.png
diff --git a/end-to-end-test/remote/specs/core/studyview.spec.js b/end-to-end-test/remote/specs/core/studyview.spec.js
@@ -248,27 +248,19 @@ describe('study laml_tcga tests', () => {
  });
 });
 
-describe('add chart should not be shown in other irrelevant tabs', () => {
+describe.only('add chart should not be shown in other irrelevant tabs', () => {
  it('check add chart button doesnt exist on heatmap', () => {
  goToUrlAndSetLocalStorage(`${CBIOPORTAL_URL}/study?id=brca_tcga_pub`);
  waitForNetworkQuiet(30000);
- $('#studyViewTabs a.tabAnchor_heatmaps').waitForDisplayed({
- timeout: WAIT_FOR_VISIBLE_TIMEOUT,
- });
- $('#studyViewTabs a.tabAnchor_heatmaps').click();
- assert(!$(ADD_CHART_BUTTON).isExisting());
- });
- it('should hide add chart button on clinical data tab', () => {
- goToUrlAndSetLocalStorage(`${CBIOPORTAL_URL}/study?id=brca_tcga_pub`);
- waitForNetworkQuiet(30000);
+
  $('#studyViewTabs a.tabAnchor_clinicalData').waitForDisplayed({
  timeout: WAIT_FOR_VISIBLE_TIMEOUT,
  });
- $('#studyViewTabs a.tabAnchor_clinicalData').click();
 
- // unfortunately we just re-use button for columns instead of changing component
- // so only way to test identity of button is to look at its contents
- assert.equal(getTextFromElement(ADD_CHART_BUTTON), 'Columns ▾');
+ assert($('button=Charts ▾').isExisting());
+
+ $('#studyViewTabs a.tabAnchor_clinicalData').click();
+ assert(!$('button=Charts ▾').isExisting());
  });
 });
 

diff --git a/src/globalStyles/e2etest.scss b/src/globalStyles/e2etest.scss
@@ -38,4 +38,8 @@
  bottom: 0;
  zindex: 999999999;
  }
+
+ .tabAnchor_heatmaps {
+ display: none;
+ }
 }