fix submission of patient and sample ids (#4943)

cBioPortal · Jul 11, 2024 · e9de2cc · e9de2cc
1 parent abd9c78
commit e9de2cc
Showing 1 changed file with 16 additions and 7 deletions.
diff --git a/src/pages/studyView/tabs/ClinicalDataTab.tsx b/src/pages/studyView/tabs/ClinicalDataTab.tsx
@@ -149,12 +149,22 @@ export class ClinicalDataTab extends React.Component<
 
     @computed
     get clinicalDataSortAttributeId(): string | undefined {
-        return this.clinicalDataSortCriteria?.field
-            ? this.props.store.clinicalAttributeDisplayNameToClinicalAttribute
-                  .result![this.clinicalDataSortCriteria.field][
-                  'clinicalAttributeId'
-              ]
-            : undefined;
+        switch (this.clinicalDataSortCriteria?.field) {
+            // these first two are special cases where we are not filtering
+            // by an attribute
+            case 'Patient ID':
+                return 'patientId';
+            case 'Sample ID':
+                return 'sampleId';
+            default:
+                return this.clinicalDataSortCriteria?.field
+                    ? this.props.store
+                          .clinicalAttributeDisplayNameToClinicalAttribute
+                          .result![this.clinicalDataSortCriteria.field][
+                          'clinicalAttributeId'
+                      ]
+                    : undefined;
+        }
     }
 
     @computed
@@ -174,7 +184,6 @@ export class ClinicalDataTab extends React.Component<
             if (this.props.store.selectedSamples.result.length === 0) {
                 return Promise.resolve({ totalItems: 0, data: [] });
             }
-
             const sampleClinicalData = await fetchClinicalDataForStudyViewClinicalDataTab(
                 this.props.store.filters,
                 this.props.store.sampleSetByKey.result!,