Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For custom selection of patients/samples allow multiple types of whitespace #11273

Open
inodb opened this issue Dec 11, 2024 · 4 comments · May be fixed by cBioPortal/cbioportal-frontend#5064
Open

For custom selection of patients/samples allow multiple types of whitespace #11273

inodb opened this issue Dec 11, 2024 · 4 comments · May be fixed by cBioPortal/cbioportal-frontend#5064
Labels
enhancement good first issue

Comments

@inodb
Copy link
Member

inodb commented Dec 11, 2024

image

The custom selection field is very stringent on the Study View. It only allows newlines, let's also allow spaces/tabs/commas
@anshuman-rai-27
Copy link

hey i undertood the requirements plz assign me this issue

@anshuman-rai-27
Copy link

hey but was wondering that spaces may create problem as if someone puts space here and there it may create problem so would suggest using tabs new line and commas for seperation only , @inodb , should i include space functionality too ?

@anshuman-rai-27 anshuman-rai-27 linked a pull request Dec 12, 2024 that will close this issue
Open
3 tasks
@LakshayPuhal
Copy link

I would like to work on this issue.

@karthik-nair-20 karthik-nair-20 mentioned this issue Dec 22, 2024
Draft
@karthik-nair-20
Copy link

Hello @inodb ,

I hope you are doing well

I wanted to inform that I have drafted a PR cBioPortal/cbioportal-frontend#5071 for this Request, I would really appreciate it if you could take a moment to review my solution and share your feedback.

Best,
Karthik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

custom-selection-added anshuman-rai-27/cbioportal-frontend
4 participants
@inodb @anshuman-rai-27 @karthik-nair-20 @LakshayPuhal