Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom-selection-added #5064

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Conversation

anshuman-rai-27
Copy link
Contributor

@anshuman-rai-27 anshuman-rai-27 commented Dec 12, 2024

Fix cBioPortal/cbioportal#11273

Describe changes proposed in this pull request:

  • added custom selection text box to take inputs with commas, space or new line or all combined also
  • also added examplary placeholder

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Any screenshots or GIFs?

Screenshot from 2024-12-12 23-32-38
Screenshot from 2024-12-12 23-48-43

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit c039542
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/6772b437ca061e000801206a
😎 Deploy Preview https://deploy-preview-5064.cancerrevue.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@anshuman-rai-27
Copy link
Contributor Author

@inodb plz review this pr , and suggest the required changes

Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @anshuman-rai-27 ! Looks great!

@inodb inodb merged commit 2c5ff74 into cBioPortal:master Dec 30, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For custom selection of patients/samples allow multiple types of whitespace
2 participants