Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide timeline events availability chart by default #10733

Open
inodb opened this issue Apr 3, 2024 · 4 comments · May be fixed by cBioPortal/cbioportal-frontend#5066
Open

hide timeline events availability chart by default #10733

inodb opened this issue Apr 3, 2024 · 4 comments · May be fixed by cBioPortal/cbioportal-frontend#5066

Comments

@inodb
Copy link
Member

inodb commented Apr 3, 2024

Hide this chart by default:

image

See this study:

https://www.cbioportal.org/study/summary?id=lgg_ucsf_2014

Requested by GENIE

@Nithin9585
Copy link

Hiding the chart by default might be easy, but it could also make it less discoverable for users who need it. Here are some alternative ideas:
WhatsApp Image 2024-04-06 at 23 06 08_6df58e96

Collapsible chart: Allow users to hide/expand the chart.
Toggle button: Provide a quick way to show/hide the chart.
Settings menu: Give users control over what elements they see. I have experience with web development (HTML, CSS, JS) and might be able to help implement these if needed.

@alisman alisman self-assigned this Apr 11, 2024
@mhsh312
Copy link

mhsh312 commented Apr 12, 2024

Hi @alisman are you working on this?

@mhsh312
Copy link

mhsh312 commented Apr 12, 2024

Hi @inodb I have a question regarding this issue. The way I understand this is there should be a list of sorts that records which charts to show by default. I just need to remove Timeline Events Availability(or CLINICAL_EVENT_TYPE_COUNTS_TABLE) from that list. The problem is I am having trouble finding that list. I did find where the priorities are mentioned in StudyViewConfig.ts:

https://github.com/cBioPortal/cbioportal-frontend/blob/ff03554180e62481bdc240acd5521601b07d124a/src/pages/studyView/StudyViewConfig.ts#L141-L143

But how does the system decide which charts to show by default?

@ShahKirtan2003
Copy link

@inodb Was really interested to resolve this issue and to engage with the codebase in depth. Please review this PR! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants