Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/10733: Updated default value of Timeline events availability chart #5066

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ShahKirtan2003
Copy link

@ShahKirtan2003 ShahKirtan2003 commented Dec 14, 2024

Fix cBioPortal/cbioportal#10733

  • As described in the issue, modified the default value of the Timeline events availability chart and not show that table by default, and let users add whenever they want from the charts menu.

image
image

Copy link

netlify bot commented Dec 14, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit 7d24e92
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/675dc9d7118418000888252c
😎 Deploy Preview https://deploy-preview-5066.cancerrevue.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines 7816 to 7820
if (this.shouldDisplayClinicalEventTypeCounts.result) {
this.changeChartVisibility(
SpecialChartsUniqueKeyEnum.CLINICAL_EVENT_TYPE_COUNTS,
true
false
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahKirtan2003 wondering if this whole block can be removed? I guess the default is to hide the chart?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hide timeline events availability chart by default
2 participants