Remove extra log calculation for Log Ratio #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisman
reviewed
Jun 21, 2018
| ExpressionEnrichmentRow[] { | ||
|
|
||
| const assumeLogSpace = expressionEnrichments.filter(a => a.meanExpressionInAlteredGroup <= 0 | ||
| || a.meanExpressionInUnalteredGroup <= 0).length > 0; | ||
|
|
||
| return expressionEnrichments.map(expressionEnrichment => { | ||
| return { | ||
| checked: gueryGenes.includes(expressionEnrichment.hugoGeneSymbol), |
There was a problem hiding this comment.
should it be "queryGenes" ?
There was a problem hiding this comment.
haha yeah, will fix :)
alisman
reviewed
Jun 21, 2018
| @@ -163,8 +163,8 @@ export default class MiniBoxPlot extends React.Component<IMiniBoxPlotProps, {}> | |||
| </VictoryChart> | |||
| </div> | |||
| {this.tooltipModel && | |||
| <Popover positionLeft={this.tooltipModel.x + 22} | |||
| positionTop={this.tooltipModel.y - 22} className="cbioTooltip" | |||
| <Popover positionLeft={this.tooltipModel.x + 16} | |||
There was a problem hiding this comment.
seems like we should strive to separate this kind of tweak from the logical change above into two commits.
alisman
approved these changes
Jun 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in cBioPortal/cbioportal#4374
Also fixes tooltip positions (probably broke after some style changes)