-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cna and putative driver coloring in expression tab #1377
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
2332cfb
expression tab - cna and putative driver coloring
0e41020
Do not show Sort By in expression tab w only one visible study
5c91d30
Update screenshots
c77c6e3
box plot - flatten labels for horizontal legend, put on bottom in exp…
d66cfb3
box plot - dont wrap tick labels
fc8caac
Box plot - dont use zero values in calculating boxes
3bbb39f
refine padding spec in boxplot and use in expression tab. shrink expr…
f1ff8b9
Adjust expression tooltips
b68f81d
Adjustments to box plot padding
d0f1f9c
box and scatterplot - multiple VictoryScatter elements to improve per…
ada37f1
Handle render order in a different way
eccf26c
plots tab - add cbioTooltip class to tooltips
eccea81
Expression tab - Move driver annotation message outside chart border
b8d6926
box and scatter plot - Reduce right padding when no legend is there
4b2b06c
box plot - Change tick label orientation
9e8b04e
box and scatter plot - Put cbioTooltip class on Popover
64df615
Update screenshots
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
+18.8 KB
(120%)
...eenshots/reference/expression_tab_with_complex_oql_element_chrome_1600x1000.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-175 Bytes
(100%)
...d-tests/screenshots/reference/no_session_plots_tab_element_chrome_1600x1000.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+5.43 KB
(100%)
...s/reference/plots_tab_clinical_vs_clinical_boxplot_element_chrome_1600x1000.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-668 Bytes
(100%)
.../reference/plots_tab_clinical_vs_molecular_boxplot_element_chrome_1600x1000.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.64 KB
(99%)
...eenshots/reference/plots_tab_clinical_vs_molecular_element_chrome_1600x1000.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+2.62 KB
(100%)
...molecular_vs_clinical_boxplot,_mutation_search_off_element_chrome_1600x1000.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+3.91 KB
(100%)
...screenshots/reference/plots_tab_mutation_type_view_element_chrome_1600x1000.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4.92 KB
(91%)
...nce/plots_tab_one_box_clinical_vs_clinical_boxplot_element_chrome_1600x1000.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+8.79 KB
(110%)
...tab_search_case_id_in_clinical_vs_clinical_boxplot_element_chrome_1600x1000.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-175 Bytes
(100%)
...-end-tests/screenshots/reference/session_plots_tab_element_chrome_1600x1000.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
putative driver contains rnaseq and mutations data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, no I just rewrote it to use numericGeneMolecularDataCache as a data source