Use TablePaginationControls for patient cohort nav #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisman
reviewed
Jan 27, 2017
| @@ -230,6 +234,29 @@ export default class PatientViewPage extends React.Component<IPatientViewPagePro | |||
|
|
|||
| } | |||
|
|
|||
| private getURL(caseId:string='', studyId:string='', cohort:string[]=[]) { | |||
There was a problem hiding this comment.
maybe buildUrl would be better name
| @@ -247,6 +275,40 @@ export default class PatientViewPage extends React.Component<IPatientViewPagePro | |||
| }); | |||
| } | |||
|
|
|||
| if (this.patientIdsInCohort && this.patientIdsInCohort.length > 0) { | |||
There was a problem hiding this comment.
why not put this in state?
There was a problem hiding this comment.
could do that too. I think I have it like this because the other URL parameters (studyId, patientId) are handled like this
| nextPageDisabled={indexInCohort === this.patientIdsInCohort.length-1} | ||
| lastPageDisabled={indexInCohort === this.patientIdsInCohort.length-1} | ||
| onFirstPageClick={() => | ||
| window.location.href = this.getURL( |
There was a problem hiding this comment.
next week lets try to handle this without page refresh. that's the holy grail and it shouldn't be too hard.
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
adamabeshouse
force-pushed
the
patient-prev-next
branch
from
ef6f342 to
3a69ef1
Compare
onursumer
pushed a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
May 19, 2022
Small typescript changes, and expose more to import
onursumer
pushed a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
May 20, 2022
Small typescript changes, and expose more to import
onursumer
pushed a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
May 23, 2022
Small typescript changes, and expose more to import
onursumer
pushed a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
May 24, 2022
Small typescript changes, and expose more to import
onursumer
pushed a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
May 25, 2022
Small typescript changes, and expose more to import
onursumer
pushed a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
May 26, 2022
Small typescript changes, and expose more to import
onursumer
pushed a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
May 27, 2022
Small typescript changes, and expose more to import
onursumer
pushed a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
May 27, 2022
Small typescript changes, and expose more to import
alisman
pushed a commit
to alisman/cbioportal-frontend
that referenced
this pull request
Jun 2, 2022
Small typescript changes, and expose more to import
onursumer
pushed a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
Jun 6, 2022
Small typescript changes, and expose more to import
onursumer
pushed a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
Jun 6, 2022
Small typescript changes, and expose more to import
alisman
pushed a commit
to onursumer/cbioportal-frontend
that referenced
this pull request
Jun 8, 2022
Small typescript changes, and expose more to import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks
can be automatically added by git if you run the
git-commitcommand withthe
-soption)