Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotspot client and data type improvements #141

Merged
merged 1 commit into from
Jan 30, 2017

Conversation

onursumer
Copy link
Member

What? Why?

Cancer Hotspots API client and data type improvements

Checks

  • Follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Follows the Airbnb React/JSX Style guide.
  • Make sure your commit messages end with a Signed-off-by string (this line
    can be automatically added by git if you run the git-commit command with
    the -s option)

@onursumer
Copy link
Member Author

@onursumer
Copy link
Member Author

Copy link
Contributor

@adamabeshouse adamabeshouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you explain what you've improved about the client? I see the changes but don't understand enough about it to understand their significance.

@onursumer
Copy link
Member Author

onursumer commented Jan 27, 2017

@adamabeshouse Actually, I improved the cancer hotspots API, and re-generated the client code here. So, I should've said "updated the client" instead :)

For the actual API improvements see: cBioPortal/cancerhotspots#56. Improvements are mostly related to parameter configuration (body parameter vs. request parameter). Seems like I wasn't using the correct parameter types in the API.

@onursumer
Copy link
Member Author

We are still missing the data fields for the types defined within the client, but we can deal with it later. Hopefully updating the code generator will fix that problem at some point since we don't have that problem with the online client generator (http://editor.swagger.io/)

@alisman alisman merged commit deb9ef9 into cBioPortal:integration Jan 30, 2017
@onursumer onursumer deleted the hotspots-client branch February 1, 2017 03:56
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 19, 2022
…yarn/ini-1.3.8

Bump ini from 1.3.5 to 1.3.8
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 20, 2022
…yarn/ini-1.3.8

Bump ini from 1.3.5 to 1.3.8
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 23, 2022
…yarn/ini-1.3.8

Bump ini from 1.3.5 to 1.3.8
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 24, 2022
…yarn/ini-1.3.8

Bump ini from 1.3.5 to 1.3.8
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 25, 2022
…yarn/ini-1.3.8

Bump ini from 1.3.5 to 1.3.8
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 26, 2022
…yarn/ini-1.3.8

Bump ini from 1.3.5 to 1.3.8
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 27, 2022
…yarn/ini-1.3.8

Bump ini from 1.3.5 to 1.3.8
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 27, 2022
…yarn/ini-1.3.8

Bump ini from 1.3.5 to 1.3.8
alisman pushed a commit to alisman/cbioportal-frontend that referenced this pull request Jun 2, 2022
…yarn/ini-1.3.8

Bump ini from 1.3.5 to 1.3.8
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request Jun 6, 2022
…yarn/ini-1.3.8

Bump ini from 1.3.5 to 1.3.8
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request Jun 6, 2022
…yarn/ini-1.3.8

Bump ini from 1.3.5 to 1.3.8
alisman pushed a commit to onursumer/cbioportal-frontend that referenced this pull request Jun 8, 2022
…yarn/ini-1.3.8

Bump ini from 1.3.5 to 1.3.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants