-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotspot client and data type improvements #141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could you explain what you've improved about the client? I see the changes but don't understand enough about it to understand their significance.
4aaa66d
to
2bb8860
Compare
@adamabeshouse Actually, I improved the cancer hotspots API, and re-generated the client code here. So, I should've said "updated the client" instead :) For the actual API improvements see: cBioPortal/cancerhotspots#56. Improvements are mostly related to parameter configuration (body parameter vs. request parameter). Seems like I wasn't using the correct parameter types in the API. |
We are still missing the data fields for the types defined within the client, but we can deal with it later. Hopefully updating the code generator will fix that problem at some point since we don't have that problem with the online client generator (http://editor.swagger.io/) |
…yarn/ini-1.3.8 Bump ini from 1.3.5 to 1.3.8
…yarn/ini-1.3.8 Bump ini from 1.3.5 to 1.3.8
…yarn/ini-1.3.8 Bump ini from 1.3.5 to 1.3.8
…yarn/ini-1.3.8 Bump ini from 1.3.5 to 1.3.8
…yarn/ini-1.3.8 Bump ini from 1.3.5 to 1.3.8
…yarn/ini-1.3.8 Bump ini from 1.3.5 to 1.3.8
…yarn/ini-1.3.8 Bump ini from 1.3.5 to 1.3.8
…yarn/ini-1.3.8 Bump ini from 1.3.5 to 1.3.8
…yarn/ini-1.3.8 Bump ini from 1.3.5 to 1.3.8
…yarn/ini-1.3.8 Bump ini from 1.3.5 to 1.3.8
…yarn/ini-1.3.8 Bump ini from 1.3.5 to 1.3.8
…yarn/ini-1.3.8 Bump ini from 1.3.5 to 1.3.8
What? Why?
Cancer Hotspots API client and data type improvements
Checks
can be automatically added by git if you run the
git-commit
command withthe
-s
option)