Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement filter typing delay, default 400ms (feels good to me) #143

Merged
merged 1 commit into from
Jan 31, 2017

Conversation

adamabeshouse
Copy link
Contributor

@adamabeshouse adamabeshouse commented Jan 31, 2017

Checks

  • Follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Follows the Airbnb React/JSX Style guide.
  • Make sure your commit messages end with a Signed-off-by string (this line
    can be automatically added by git if you run the git-commit command with
    the -s option)

Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (integration@2bd429d).


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bd429d...5e50647. Read the comment docs.

@jjgao jjgao temporarily deployed to cbioportal-frontend-pr-143 January 31, 2017 00:19 Inactive
@adamabeshouse
Copy link
Contributor Author

Copy link
Member

@onursumer onursumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like working fine!

@alisman alisman merged commit d850508 into cBioPortal:integration Jan 31, 2017
@adamabeshouse adamabeshouse deleted the add-search-box-delay branch August 7, 2018 17:05
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 19, 2022
…yarn/y18n-4.0.1

Bump y18n from 4.0.0 to 4.0.1
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 20, 2022
…yarn/y18n-4.0.1

Bump y18n from 4.0.0 to 4.0.1
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 23, 2022
…yarn/y18n-4.0.1

Bump y18n from 4.0.0 to 4.0.1
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 24, 2022
…yarn/y18n-4.0.1

Bump y18n from 4.0.0 to 4.0.1
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 25, 2022
…yarn/y18n-4.0.1

Bump y18n from 4.0.0 to 4.0.1
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 26, 2022
…yarn/y18n-4.0.1

Bump y18n from 4.0.0 to 4.0.1
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 27, 2022
…yarn/y18n-4.0.1

Bump y18n from 4.0.0 to 4.0.1
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 27, 2022
…yarn/y18n-4.0.1

Bump y18n from 4.0.0 to 4.0.1
alisman pushed a commit to alisman/cbioportal-frontend that referenced this pull request Jun 2, 2022
…yarn/y18n-4.0.1

Bump y18n from 4.0.0 to 4.0.1
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request Jun 6, 2022
…yarn/y18n-4.0.1

Bump y18n from 4.0.0 to 4.0.1
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request Jun 6, 2022
…yarn/y18n-4.0.1

Bump y18n from 4.0.0 to 4.0.1
alisman pushed a commit to onursumer/cbioportal-frontend that referenced this pull request Jun 8, 2022
…yarn/y18n-4.0.1

Bump y18n from 4.0.0 to 4.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants