Show/Hide bug fix

[onursumer]

What? Why?

Fixes and improves the show/hide feature behavior.

Checks

• Follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
• Follows the Airbnb React/JSX Style guide.
• Make sure your commit messages end with a Signed-off-by string (this line
  can be automatically added by git if you run the git-commit command with
  the -s option)

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (integration@3eabf55).

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eabf55...561529d. Read the comment docs.

[onursumer]

(3) fix show/hide

[onursumer]

@alisman @adamabeshouse The fix is actually one line to make the show/hide work again: https://github.com/cBioPortal/cbioportal-frontend/pull/144/files#diff-dd74d85f67f0228723795bf4b6f21e1dR497

But I also made some improvements. Basically, now the generateRows method is called only when the column definitions are updated (since we are passing additional data via columnProps within the column definition). Change in columnVisibility now only affects generateHeaders, not generateRows anymore. Updating the Thead is sufficient to show/hide columns, since reactable is smart enough to ignore Td components with an unknown column value.

[adamabeshouse]

Looks good but I just have that one naming comment

[adamabeshouse]

this name doesn't make sense to me/is sort of vague. It's not quite a verb, not quite a noun. I think it should be sortableColumns or something. same with columnFilter

[onursumer]

okay, let's change to sortableColumns and filterableColumns.