Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finish writing SampleManager.getColorForSample #152

Merged

Conversation

adamabeshouse
Copy link
Contributor

@adamabeshouse adamabeshouse commented Jan 31, 2017

Fix https://github.com/cBioPortal/cbioportal-frontend/issues/146

Checks

  • Follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Follows the Airbnb React/JSX Style guide.
  • Make sure your commit messages end with a Signed-off-by string (this line
    can be automatically added by git if you run the git-commit command with
    the -s option)

Any screenshots or GIFs?

image

Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
@adamabeshouse adamabeshouse requested a review from inodb January 31, 2017 19:28
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (integration@3eabf55).


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eabf55...7e50471. Read the comment docs.

@alisman alisman merged commit b58ee64 into cBioPortal:integration Jan 31, 2017
@adamabeshouse adamabeshouse deleted the bar-color-in-allele-freq branch August 7, 2018 17:05
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 19, 2022
…yarn/tar-4.4.15

Bump tar from 4.4.13 to 4.4.15
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 20, 2022
…yarn/tar-4.4.15

Bump tar from 4.4.13 to 4.4.15
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 23, 2022
…yarn/tar-4.4.15

Bump tar from 4.4.13 to 4.4.15
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 24, 2022
…yarn/tar-4.4.15

Bump tar from 4.4.13 to 4.4.15
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 25, 2022
…yarn/tar-4.4.15

Bump tar from 4.4.13 to 4.4.15
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 26, 2022
…yarn/tar-4.4.15

Bump tar from 4.4.13 to 4.4.15
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 27, 2022
…yarn/tar-4.4.15

Bump tar from 4.4.13 to 4.4.15
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 27, 2022
…yarn/tar-4.4.15

Bump tar from 4.4.13 to 4.4.15
alisman pushed a commit to alisman/cbioportal-frontend that referenced this pull request Jun 2, 2022
…yarn/tar-4.4.15

Bump tar from 4.4.13 to 4.4.15
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request Jun 6, 2022
…yarn/tar-4.4.15

Bump tar from 4.4.13 to 4.4.15
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request Jun 6, 2022
…yarn/tar-4.4.15

Bump tar from 4.4.13 to 4.4.15
alisman pushed a commit to onursumer/cbioportal-frontend that referenced this pull request Jun 8, 2022
…yarn/tar-4.4.15

Bump tar from 4.4.13 to 4.4.15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants