Fork query experience #2498
Fork query experience #2498
Conversation
src/pages/home/HomePage.tsx
Outdated
| @@ -78,12 +78,22 @@ export default class HomePage extends React.Component<IResultsViewPageProps, {}> | |||
|
|
|||
| return ( | |||
| <PageLayout className="homePageLayout" noMargin={true} rightBar={<RightBar queryStore={this.queryStore} />}> | |||
| {/*<div className={"headBlock"} dangerouslySetInnerHTML={{__html:AppConfig.serverConfig.skin_blurb!}}></div>*/} | |||
There was a problem hiding this comment.
i actually have to restore this to support other portals
src/pages/home/HomePage.tsx
Outdated
| <div className={"headBlock"} style={{paddingBottom:0}}> | ||
|
|
||
| <div className={"citationRule"}> | ||
| Please cite: <a href="http://cancerdiscovery.aacrjournals.org/content/2/5/401.abstract" target="_blank">Cerami et al., 2012</a> & <a href="http://www.ncbi.nlm.nih.gov/pubmed/23550210" target="_blank">Gao et al., 2013</a> |
There was a problem hiding this comment.
this will become configurable
| ); | ||
| } | ||
| } | ||
| import * as React from "react"; |
There was a problem hiding this comment.
finally changing newline style from days of Andy windows format
| @@ -18,7 +22,7 @@ var searchInputSelector = ".autosuggest input[type=text]"; | |||
|
|
|||
| describe('homepage', function() { | |||
|
|
|||
| this.retries(2); | |||
| this.retries(0); | |||
| waitForNumberOfStudyCheckboxes, | ||
| clickModifyStudySelectionButton | ||
| } = require('./../specUtils'); | ||
|
|
|
I'm seeing excess space on the bottom in firefox this also causes the unpleasant UI of if you click on "query by gene" when all the way scrolled down, it doesnt scroll you back up when the study section collapses: |
|
the modify query screen should just fill the screen I think, right now it overshoots it
|
| @@ -138,6 +138,7 @@ export default class QuerySummary extends React.Component<{ routingStore:Extende | |||
| @computed get queryForm(){ | |||
| return <div style={{margin:"10px -20px 0 -20px"}}> | |||
| <QueryAndDownloadTabs onSubmit={this.onSubmit} | |||
| forkedExperience={false} | |||
There was a problem hiding this comment.
I find it vague, can you rename this prop, maybe "bigStudyViewButtonMode" or something?
There was a problem hiding this comment.
What about forkedMode? I actually think "forkedXXX" is more descriptive. It at least hints at the concept behind this mode. If we can come up with a better name than "forked" I'm open to it. I will change to mode because it's better than "experience" for sure.
There was a problem hiding this comment.
sure, that works for me
| {/* <Observer>*/} | ||
| {/* {() => {*/} | ||
| {/* let hasSelection = this.store.selectableSelectedStudyIds.length > 0;*/} | ||
|
|
There was a problem hiding this comment.
still need this code?
| {this.store.oqlMessages.map(msg => { | ||
| return ( | ||
| <span className={styles.oqlMessage}> | ||
| <i className='fa fa-info-circle' style={{marginRight: 5}}/> |
There was a problem hiding this comment.
some formatting issues here? wouldnt necessarily mention it besides that you're doing a reformat
| <a | ||
| onClick={() => { | ||
| if (numSelectedStudies) | ||
| props.store.showSelectedStudiesOnly = !props.store.showSelectedStudiesOnly; |
There was a problem hiding this comment.
a bit hard on the eye in this context, could you put it in brackets even though its just one line?
|
|
||
| } | ||
| a { | ||
| pointer-events:all !important; |
…ow study selector.
Break homepage experience into two steps: 1. choose study, 2. if query by gene, show query criteria UI
(hidden by default)
This will help users see the study page as a first-class citizen, sibling of results view. Right now, most users submit queries and don't visit study view, suggesting that perhaps they don't know how to navigate to it.
Also, make study chooser height responsive.
Fixes: cBioPortal/cbioportal#6363