Upgraded react-mutation-mapper version to 0.3.0 #2706

onursumer · 2019-09-17T18:44:43Z

Before:

After:

Checks

Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!
Follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
Follows the Airbnb React/JSX Style guide.
Make sure your commit messages end with a Signed-off-by string (this line
can be automatically added by git if you run the git-commit command with
the -s option)

onursumer · 2019-09-19T20:46:20Z

src/shared/components/mutationMapper/MutationMapperStore.ts

@@ -130,43 +130,6 @@ export default class MutationMapperStore extends DefaultMutationMapperStore
        return mutation.gene.entrezGeneId;
    }

-    @autobind
-    protected customFilterApplier(filter: DataFilter,


This logic has been moved as multiple separate methods into https://github.com/cBioPortal/react-mutation-mapper/blob/66648ae9b966f7a30069e397acfb0e6efc0a0c73/src/store/DefaultMutationMapperFilterApplier.ts#L24

onursumer · 2019-09-19T20:47:51Z

src/shared/components/mutationMapper/MutationMapper.tsx

@@ -188,18 +201,6 @@ export default class MutationMapper<P extends IMutationMapperProps> extends Defa
        ): null;
    }

-    protected get proteinImpactTypePanel(): JSX.Element | null


now we are using ProteinImpactTypeBadgeSelector component to enable multiple filtering

onursumer · 2019-09-19T20:49:49Z

src/pages/resultsView/mutation/MutationRateSummary.tsx

-                {this.somaticMutationFrequency()}
-                {this.germlineMutationFrequency()}
-            </div>
+            <MutationStatusSelector


This enables filtering by mutation status (somatic / germline)

package.json

alisman · 2019-10-04T20:31:14Z

@onursumer is this still draft? what's story?

onursumer · 2019-10-17T14:12:37Z

@alisman we can merge this as soon as Niki approves the latest UI changes. I still need to update the screenshot tests though.

alisman · 2019-11-18T20:57:28Z

src/shared/components/mutationMapper/MutationMapper.tsx

@@ -171,6 +186,10 @@ export default class MutationMapper<P extends IMutationMapperProps> extends Defa
                trackDataStatus={this.trackDataStatus}
                onTrackVisibilityChange={this.onTrackVisibilityChange}
                getLollipopColor={getColorForProteinImpactType}
+                filterResetPanel={
+                    !this.props.store.dataStore.showingAllData && this.filterResetPanel ?


could you just pass filterResetPanel whether it's defined or not? just kind confusing

The problem here is, for some reason, we initially defined filterResetPanel as JSX.Element | null instead of JSX.Element | undefined. When I just pass it, TS complains that null cannot be assigned to undefined.

For now just updated the check to this.filterResetPanel !== null, but we should probably revisit those function definitions (both here and in react-mutation-mapper)

alisman · 2019-11-18T21:00:26Z

src/shared/components/mutationMapper/MutationMapperDataStore.ts

+export const PROTEIN_IMPACT_TYPE_FILTER_ID = "_cBioPortalProteinImpactTypeFilter_";
+export const MUTATION_STATUS_FILTER_ID = "_cBioPortalMutationStatusFilter_";
+
+export function findMutationTypeFilter(dataFilters: DataFilter[])


function name sees strange because code finds a particular type of filter, right? shouldn't function name suggest that?

renamed to findProteinImpactTypeFilter

Signed-off-by: Onur Sumer <s.onur.sumer@gmail.com> replaced ProteinImpactTypePanel with ProteinImpactTypeBadgeSelector Signed-off-by: Onur Sumer <s.onur.sumer@gmail.com> enabled filtering for MutationRateSummary Signed-off-by: Onur Sumer <s.onur.sumer@gmail.com> fixed mutation type filter counts Signed-off-by: Onur Sumer <s.onur.sumer@gmail.com>

Signed-off-by: Onur Sumer <s.onur.sumer@gmail.com>

onursumer force-pushed the react-mutation-mapper-0.3.0 branch 3 times, most recently from 2056fe5 to 76bb3ab Compare September 19, 2019 20:43

onursumer commented Sep 19, 2019

View reviewed changes

onursumer force-pushed the react-mutation-mapper-0.3.0 branch from 76bb3ab to 902f4d7 Compare September 19, 2019 21:29

jjgao temporarily deployed to cbioportal-frontend-pr-2706 September 19, 2019 21:45 Inactive

onursumer force-pushed the react-mutation-mapper-0.3.0 branch from 902f4d7 to b19f410 Compare September 20, 2019 17:32

jjgao temporarily deployed to cbioportal-frontend-pr-2706 September 20, 2019 17:32 Inactive

onursumer force-pushed the react-mutation-mapper-0.3.0 branch from b19f410 to a48621b Compare October 15, 2019 21:46

jjgao had a problem deploying to cbioportal-frontend-pr-2706 October 15, 2019 21:46 Failure

onursumer force-pushed the react-mutation-mapper-0.3.0 branch from a48621b to 59cafe1 Compare October 16, 2019 21:50

jjgao deployed to cbioportal-frontend-pr-2706 October 16, 2019 21:50 View deployment

jjgao temporarily deployed to cbioportal-f-react-muta-ju2brr October 23, 2019 18:58 Inactive

onursumer force-pushed the react-mutation-mapper-0.3.0 branch from 59cafe1 to 41af9f9 Compare October 28, 2019 07:59

jjgao temporarily deployed to cbioportal-f-react-muta-ju2brr October 28, 2019 07:59 Inactive

onursumer force-pushed the react-mutation-mapper-0.3.0 branch from 41af9f9 to 10b09f3 Compare October 28, 2019 09:21

jjgao temporarily deployed to cbioportal-f-react-muta-ju2brr October 28, 2019 09:21 Inactive

onursumer force-pushed the react-mutation-mapper-0.3.0 branch from 10b09f3 to 043a5a3 Compare October 31, 2019 20:03

jjgao temporarily deployed to cbioportal-f-react-muta-ju2brr October 31, 2019 20:04 Inactive

onursumer force-pushed the react-mutation-mapper-0.3.0 branch from 043a5a3 to 56d8830 Compare November 1, 2019 10:09

jjgao temporarily deployed to cbioportal-f-react-muta-ju2brr November 1, 2019 10:09 Inactive

onursumer marked this pull request as ready for review November 1, 2019 10:16

onursumer requested review from alisman, zhx828, adamabeshouse and inodb November 1, 2019 10:16

adamabeshouse approved these changes Nov 1, 2019

View reviewed changes

onursumer force-pushed the react-mutation-mapper-0.3.0 branch from 56d8830 to ce6a5ac Compare November 5, 2019 18:42

onursumer force-pushed the react-mutation-mapper-0.3.0 branch from cf5cdee to ee56378 Compare November 14, 2019 17:26

jjgao temporarily deployed to cbioportal-f-react-muta-ju2brr November 14, 2019 17:26 Inactive

onursumer force-pushed the react-mutation-mapper-0.3.0 branch from ee56378 to ddb5a42 Compare November 14, 2019 18:23

jjgao temporarily deployed to cbioportal-f-react-muta-ju2brr November 14, 2019 18:24 Inactive

onursumer force-pushed the react-mutation-mapper-0.3.0 branch from ddb5a42 to 469bd76 Compare November 15, 2019 16:51

jjgao temporarily deployed to cbioportal-f-react-muta-ju2brr November 15, 2019 16:51 Inactive

onursumer force-pushed the react-mutation-mapper-0.3.0 branch from 469bd76 to 3e38a15 Compare November 15, 2019 17:22

jjgao temporarily deployed to cbioportal-f-react-muta-ju2brr November 15, 2019 17:23 Inactive

onursumer force-pushed the react-mutation-mapper-0.3.0 branch from 3e38a15 to d9f58eb Compare November 18, 2019 16:50

jjgao temporarily deployed to cbioportal-f-react-muta-ju2brr November 18, 2019 16:50 Inactive

onursumer force-pushed the react-mutation-mapper-0.3.0 branch from d9f58eb to 5a16964 Compare November 18, 2019 20:06

jjgao temporarily deployed to cbioportal-f-react-muta-ju2brr November 18, 2019 20:07 Inactive

alisman reviewed Nov 18, 2019

View reviewed changes

onursumer force-pushed the react-mutation-mapper-0.3.0 branch 2 times, most recently from 5a16964 to 6edcc41 Compare November 19, 2019 02:05

jjgao temporarily deployed to cbioportal-f-react-muta-ju2brr November 19, 2019 02:05 Inactive

onursumer force-pushed the react-mutation-mapper-0.3.0 branch from 6edcc41 to d3d6979 Compare November 19, 2019 17:04

jjgao temporarily deployed to cbioportal-f-react-muta-ju2brr November 19, 2019 17:04 Inactive

onursumer force-pushed the react-mutation-mapper-0.3.0 branch from d3d6979 to a756189 Compare November 19, 2019 18:06

jjgao temporarily deployed to cbioportal-f-react-muta-ju2brr November 19, 2019 18:06 Inactive

onursumer force-pushed the react-mutation-mapper-0.3.0 branch from a756189 to b6dc4fd Compare November 19, 2019 20:31

jjgao temporarily deployed to cbioportal-f-react-muta-ju2brr November 19, 2019 20:31 Inactive

onursumer added 2 commits November 19, 2019 16:48

fixed broken tests and screenshots

21290e3

Signed-off-by: Onur Sumer <s.onur.sumer@gmail.com>

onursumer force-pushed the react-mutation-mapper-0.3.0 branch from b6dc4fd to 21290e3 Compare November 19, 2019 21:49

jjgao temporarily deployed to cbioportal-f-react-muta-ju2brr November 19, 2019 21:49 Inactive

alisman merged commit 4789052 into cBioPortal:master Nov 19, 2019

onursumer deleted the react-mutation-mapper-0.3.0 branch November 20, 2019 17:02

inodb added the feature label Nov 29, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgraded react-mutation-mapper version to 0.3.0 #2706

Upgraded react-mutation-mapper version to 0.3.0 #2706

onursumer commented Sep 17, 2019 •

edited

Loading

onursumer Sep 19, 2019

onursumer Sep 19, 2019

onursumer Sep 19, 2019

alisman commented Oct 4, 2019

onursumer commented Oct 17, 2019

alisman Nov 18, 2019

onursumer Nov 19, 2019

alisman Nov 18, 2019

onursumer Nov 19, 2019

Upgraded react-mutation-mapper version to 0.3.0 #2706

Upgraded react-mutation-mapper version to 0.3.0 #2706

Conversation

onursumer commented Sep 17, 2019 • edited Loading

Checks

onursumer Sep 19, 2019

Choose a reason for hiding this comment

onursumer Sep 19, 2019

Choose a reason for hiding this comment

onursumer Sep 19, 2019

Choose a reason for hiding this comment

alisman commented Oct 4, 2019

onursumer commented Oct 17, 2019

alisman Nov 18, 2019

Choose a reason for hiding this comment

onursumer Nov 19, 2019

Choose a reason for hiding this comment

alisman Nov 18, 2019

Choose a reason for hiding this comment

onursumer Nov 19, 2019

Choose a reason for hiding this comment

onursumer commented Sep 17, 2019 •

edited

Loading