Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clinical tracks to oncoprinter #2801

Merged
merged 15 commits into from
Nov 12, 2019

Conversation

adamabeshouse
Copy link
Contributor

@adamabeshouse adamabeshouse commented Oct 18, 2019

Allow people to input custom clinical data when using the oncoprinter on the visualize your data page: https://www.cbioportal.org/oncoprinter.

Screen Shot 2019-11-15 at 3 27 18 PM

@jjgao jjgao temporarily deployed to cbioportal-frontend-pr-2801 October 18, 2019 17:59 Inactive
@jjgao jjgao temporarily deployed to cbioportal-frontend-pr-2801 October 18, 2019 19:29 Inactive
@jjgao jjgao temporarily deployed to cbioportal-frontend-pr-2801 October 18, 2019 21:16 Inactive
@jjgao jjgao temporarily deployed to cbioportal-frontend-pr-2801 October 18, 2019 21:17 Inactive
@jjgao jjgao temporarily deployed to cbioportal-frontend-pr-2801 October 18, 2019 22:06 Inactive
@adamabeshouse adamabeshouse requested a review from alisman October 21, 2019 17:31
@jjgao jjgao temporarily deployed to cbioportal-frontend-pr-2801 October 21, 2019 17:31 Inactive
@jjgao jjgao temporarily deployed to cbioportal-frontend-pr-2801 October 21, 2019 18:27 Inactive
@jjgao jjgao temporarily deployed to cbioportal-frontend-pr-2801 October 21, 2019 18:28 Inactive
@jjgao jjgao temporarily deployed to cbioportal-frontend-pr-2801 October 21, 2019 23:09 Inactive
@jjgao jjgao temporarily deployed to cbioportal-frontend-pr-2801 October 22, 2019 16:23 Inactive
@jjgao jjgao temporarily deployed to cbioportal-frontend-pr-2801 October 22, 2019 17:14 Inactive
@jjgao jjgao temporarily deployed to cbioportal-f-oncoprinte-ui5swu October 23, 2019 18:58 Inactive
@jjgao jjgao temporarily deployed to cbioportal-f-oncoprinte-ui5swu October 30, 2019 16:08 Inactive
@jjgao jjgao temporarily deployed to cbioportal-f-oncoprinte-ui5swu November 1, 2019 18:32 Inactive
@jjgao jjgao temporarily deployed to cbioportal-f-oncoprinte-ui5swu November 6, 2019 17:27 Inactive
@jjgao jjgao temporarily deployed to cbioportal-f-oncoprinte-ui5swu November 6, 2019 21:20 Inactive
@jjgao jjgao temporarily deployed to cbioportal-f-oncoprinte-ui5swu November 6, 2019 22:38 Inactive
return ret;
}

export function parseClinicalInput(input:string):{ status:"complete", result:{ headers:AttributeSpec[], data:OncoprinterClinicalInputLine[]}, error:undefined }|{ status:"error", result:undefined, error:string } {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a comment that the response type mimics mobxpromise?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, but just for the record it's not meant to be used in "await", its just a convenient form for giving back the result

@jjgao jjgao temporarily deployed to cbioportal-f-oncoprinte-ui5swu November 7, 2019 21:13 Inactive
Abeshouse, Adam A./Sloan Kettering Institute added 15 commits November 11, 2019 17:43
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
…nted

Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
@jjgao jjgao temporarily deployed to cbioportal-f-oncoprinte-ui5swu November 11, 2019 22:43 Inactive
@adamabeshouse adamabeshouse merged commit e2fe4a3 into cBioPortal:master Nov 12, 2019
@adamabeshouse adamabeshouse deleted the oncoprinter-clin branch November 12, 2019 00:48
@inodb inodb added the feature label Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants