Global settings menu for results view page #2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisman
approved these changes
Nov 5, 2019
adamabeshouse
force-pushed
the
global-settings2
branch
from
10ab798 to
3e5e6aa
Compare
adamabeshouse
force-pushed
the
global-settings2
branch
from
3e5e6aa to
e26bffa
Compare
adamabeshouse
force-pushed
the
global-settings2
branch
from
e26bffa to
9aa9a84
Compare
adamabeshouse
force-pushed
the
global-settings2
branch
from
9aa9a84 to
7bfd65a
Compare
adamabeshouse
force-pushed
the
global-settings2
branch
from
7bfd65a to
2fa062a
Compare
adamabeshouse
force-pushed
the
global-settings2
branch
from
2fa062a to
5d93859
Compare
adamabeshouse
force-pushed
the
global-settings2
branch
from
5d93859 to
291c698
Compare
adamabeshouse
force-pushed
the
global-settings2
branch
from
7baa637 to
f75123b
Compare
adamabeshouse
force-pushed
the
global-settings2
branch
from
f75123b to
fdc4847
Compare
added 9 commits
November 21, 2019 13:37
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
This reverts commit fb4e52cbfb5453ca87678c759aa425c22e61bb56.
…nu, point to global settings Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
added 4 commits
November 21, 2019 13:38
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
adamabeshouse
force-pushed
the
global-settings2
branch
from
fdc4847 to
d6d98fa
Compare
|
@adamabeshouse Could you provide a more elaborate description for this PR? The PR titles and links to them show up directly in the relesease notes now (see e.g. https://github.com/cBioPortal/cbioportal-frontend/releases/tag/v3.1.5), so would be good to describe them in a way that someone with little knowledge of the code can understand at a high level what the changes are and why it is useful. Note that you also have control over where your PR shows up by changing the label according to the categories here: https://github.com/cBioPortal/cbioportal-frontend/blob/v3.1.5/.github/release-drafter.yml. Feel free to introduce new categories/labels in that file |
adamabeshouse
added
feature
and removed
chore
|
cool @inodb, done |
|
Thanks @adamabeshouse ! |
|
@adamabeshouse so is this the PR that introduces this menu 👇? |
|
yeah @inodb 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a menu in the main query results page in which users can control certain data filtering and annotation settings across tabs.