Always proxy oncokb request #2864
Conversation
zhx828
force-pushed
the
update-oncokb
branch
from
5ec3cf8 to
d871636
Compare
The new OncoKB website is no longer allowing cross domain requests. All requests need to be proxied and attach the auth header
zhx828
force-pushed
the
update-oncokb
branch
from
d871636 to
7aea708
Compare
| if (typeof url === 'string') { | ||
| return buildCBioPortalAPIUrl(`proxy/${trimProtocol(url)}`); | ||
| } else { | ||
| return undefined; |
There was a problem hiding this comment.
does calling code handle undefined? I guess typescript would complain if it didn't, right?
There was a problem hiding this comment.
As far as I can tell, we inject these url to the client directly bypassing the constructer. It will have problem if url is undefined. But it seems like we will never run into this scenario since we have the serverConfigDefaults defined. @alisman
|
@inodb I agree. This is a fix to make sure any instances that do not wish to upgrade to 3.2(which oncokb auth will be included) can run smoothly. This will eliminate a cross-domain issue if the oncokb instance does not allow that. |
|
I took a look places where oncokb is used. They all work properly. |
The coming up new OncoKB website is no longer allowing cross domain requests. All requests need to be proxied and attached the auth header