Allow user to customize x-axis (months survival) in survival plot #2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dippindots
force-pushed
the
survial_chart_slider
branch
from
587f320 to
eb9c81a
Compare
alisman
reviewed
Nov 21, 2019
| .value(); | ||
| } | ||
|
|
||
| @autobind |
alisman
reviewed
Nov 21, 2019
| this.sliderValue = value; | ||
| } | ||
|
|
||
| @autobind |
|
@dippindots nice work. lets add the unit (months surivval) after text box. then please send a link to Niki for final test |
|
@alisman Sure, I will update soon. Thanks for the review! |
dippindots
force-pushed
the
survial_chart_slider
branch
from
eb9c81a to
4cf3876
Compare
dippindots
force-pushed
the
survial_chart_slider
branch
from
4cf3876 to
f79c507
Compare
dippindots
force-pushed
the
survial_chart_slider
branch
from
f79c507 to
bb73515
Compare
alisman
changed the title
alisman
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/cbioportal#2176