Routing Improvements #2891
Merged
Routing Improvements #2891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luke-Sikina
requested review from
dippindots and
alisman
and removed request for
dippindots and
alisman
Luke-Sikina
commented
Nov 22, 2019
Luke-Sikina
force-pushed
the
improved-routing
branch
from
f95722d to
b58d84d
Compare
Luke-Sikina
added
style tweak
Luke-Sikina
force-pushed
the
improved-routing
branch
from
b58d84d to
9015200
Compare
|
@Luke-Sikina, so, looking at this i'm thinking that we need to take a different route (no pun intended). It's my fault. The tabId path segment /page/tabId should really be handled entirely by the tab component. If it gets fed a tabid that doesn't corrrespond to anything, it should have an error (no correpoding tab). This should be built into MSKTabs component. Lets discuss further |
Luke-Sikina
added
ready to review
DO NOT MERGE
and removed
DO NOT MERGE
ready to review
labels
alisman
approved these changes
Dec 13, 2019
Luke-Sikina
force-pushed
the
improved-routing
branch
from
9015200 to
6434643
Compare
Luke-Sikina
force-pushed
the
improved-routing
branch
from
6434643 to
bbf067f
Compare
Luke-Sikina
force-pushed
the
improved-routing
branch
from
bbf067f to
717671b
Compare
Luke-Sikina
force-pushed
the
improved-routing
branch
from
717671b to
ff1d565
Compare
Luke-Sikina
force-pushed
the
improved-routing
branch
from
89bcaad to
082fc70
Compare
- invalid subpaths (tabs) result in a 404 page - 404 page is more consistent with regular error page This reverts commit 082fc70
Luke-Sikina
force-pushed
the
improved-routing
branch
from
f54005d to
b6f1169
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/cbioportal#6768
Describe changes proposed in this pull request: