-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monorepo with yarn workspaces and lerna #2892
Conversation
45b1a4c
to
989d458
Compare
@onursumer Nice work! Just wanted to share I found something describing lerna and yarn workspaces. Maybe of interest: https://doppelmutzi.github.io/monorepo-lerna-yarn-workspaces/. Lerna seems more powerful for publishing individual packages but yarn workspaces allows skipping the bootstrap step. You can use both as well When we introduce lerna, we prolly need some docs on how to install packages. Like how to install a dependency for one of the projects vs a dependency for all of them. As well as how to run the individual projects |
b7e9a84
to
d553f85
Compare
7666e4a
to
37a733e
Compare
"clean": "rimraf dist tsDist common-dist", | ||
"build": "yarn run clean && yarn run compileOqlParser && yarn run buildDLL:prod && cross-env NODE_ENV=production NODE_OPTIONS=--max-old-space-size=2048 webpack", | ||
"build": "./scripts/env_vars.sh && eval \"$(./scripts/env_vars.sh)\" && yarn run buildAll", | ||
"buildAll": "yarn run buildModules && yarn run buildMain", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently, jitpack is the only use case where we don't need to set env vars, so we call buildAll
instead of build
there.
Signed-off-by: Onur Sumer <s.onur.sumer@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yarn workspaces
for package management -- needed to update the yarn to the latest version for this.lerna
for multi package tasks (test, build, publish, etc.)src/public-lib
contents underpackages/cbioportal-frontend-commons
with a properpackage.json
and updated references accordingly -- this increases the number of files changed dramatically, but majority of these changes are just reference updates.rollup
andts
config options to bundle modules under packages.Checks