Allow setting BACKEND on CircleCI #2896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the backend repo the e2e localdb test were giving an error because a BACKEND variable was being set in custom.sh. This changes the test to check if the commit itself contains BACKEND such that changes to custom.sh not checked in are ignored.
It seems the tooltip is no longer showing up, which is a good thing. I don't see any other errors
inodb
force-pushed
the
change-custom-BACKEND-check
branch
from
c49f85d to
92657a5
Compare
|
Also fixed the screenshot, there is some issue with updating them: cBioPortal/cbioportal#6855 |
|
Gonna merge this since it's a pretty trivial fix and would like to have ✅master branches on frontend and backend. Feel free to add comments here or open issues if u find any problems and ill try to address them. The one e2e remote test failing looks flaky: it has nothing to with the changes in this PR as far as I can tell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the backend repo the e2e localdb test were giving an error because a
BACKEND variable was being set in custom.sh. This changes the test to
check if the commit itself contains BACKEND such that changes to
custom.sh not checked in are ignored