Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove external frontend condition for localdb end to end test #4016

Merged

Conversation

onursumer
Copy link
Member

@onursumer onursumer commented Oct 29, 2021

Related to cBioPortal/cbioportal#9012

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

@onursumer onursumer force-pushed the remove-external-frontend-condition branch 3 times, most recently from fd41fd5 to 58c1f0f Compare November 2, 2021 16:01
@onursumer onursumer requested review from alisman and inodb November 2, 2021 16:07
@onursumer onursumer marked this pull request as ready for review November 2, 2021 16:07
@onursumer onursumer force-pushed the remove-external-frontend-condition branch from 58c1f0f to 13caa6d Compare November 4, 2021 10:09
@onursumer onursumer force-pushed the remove-external-frontend-condition branch from 13caa6d to 2593273 Compare November 4, 2021 15:35
Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@inodb
Copy link
Member

inodb commented Nov 5, 2021

@onursumer for this one reads_posted_data_written_by_backend_and_successfully_passes_params_into_URL_resulting_in_oncoprint_display - how should we handle it?

@onursumer
Copy link
Member Author

@onursumer for this one reads_posted_data_written_by_backend_and_successfully_passes_params_into_URL_resulting_in_oncoprint_display - how should we handle it?

@inodb this one was working previously because localdist=true was hardcoded in the url. Now we use netlify, but we cannot really hardcode netlify in the url (we don't support it in the backend). I think we should fix this in a separate PR. Maybe by supporting netlify=... in the url?

@alisman alisman merged commit 7f67477 into cBioPortal:master Nov 5, 2021
@alisman alisman deleted the remove-external-frontend-condition branch November 5, 2021 15:41
@inodb inodb added the test label Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants