Fix uniprot PTM crash when centain fields are missing in uniprot data #4034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leexgh
force-pushed
the
9033-fix-uniprot-ptm
branch
2 times, most recently
from
35bf7bb to
f583036
Compare
onursumer
reviewed
Nov 10, 2021
leexgh
force-pushed
the
9033-fix-uniprot-ptm
branch
from
f583036 to
2b516fe
Compare
leexgh
force-pushed
the
9033-fix-uniprot-ptm
branch
from
2b516fe to
19ecb46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: cBioPortal/cbioportal#9033
From Uniprot api doc, there are some option value in the model:
https://www.ebi.ac.uk/proteins/api/doc/#!/features/getByAccession
But based on my testing,
evidencescould be missing too, for example: https://www.ebi.ac.uk/proteins/api/features/P06276?categories=PTMSo we change
description,moleculeandevidencesin UniprotFeature to optional, as well asdescriptionandevidencein UniprotTopology to optional.