Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OncoKB resistance level info for annotation column download #4066

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

onursumer
Copy link
Member

Fix cBioPortal/cbioportal#9067

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

@onursumer onursumer requested a review from zhx828 November 29, 2021 14:37
Copy link
Member

@zhx828 zhx828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix! 💯

@onursumer onursumer force-pushed the fix-oncokb-dload-res-lvl branch from f1511a8 to 2dc9f46 Compare November 30, 2021 14:02
@alisman alisman merged commit e695122 into cBioPortal:master Nov 30, 2021
@alisman alisman deleted the fix-oncokb-dload-res-lvl branch November 30, 2021 20:39
@dippindots dippindots added the bug label Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mutation table download file does not include OncoKB resistance info
4 participants