-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NDEx Pathways Integration #4069
Conversation
9de217f
to
6c4fb13
Compare
@@ -47,6 +47,7 @@ const ServerConfigDefaults: Partial<IServerConfig> = { | |||
show_mutation_mapper_tool_grch38: true, | |||
show_transcript_dropdown: false, | |||
show_signal: true, | |||
show_ndex: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@inodb should this really default to true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for checking - yeah i think it makes sense to have this be the default for all installations
} | ||
|
||
if ( | ||
urlResponse && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, you can now do urlResponse?.body?.webUrl?.startWith('...')
and it will evaluate false if anything is undefined
Adds NDEx pathways on pathways tab in the results view page. Related to cBioPortal/icebox#343.
Test URL: https://bit.ly/3vddazA
TODO:
We decieded not to include other alteration frequencies yet as part of this release:
"geneAnnotationServices": { "mutation": "https://iquery-cbio.dev.ucsd.edu/integratedsearch/v1/mutationfrequency", "alteration": "http://localhost/" }
Follow up with tests: cBioPortal/icebox#331
Let's use squash on merge button