Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fetch structural variants data when there are no applicable samples #4089

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

dippindots
Copy link
Member

@dippindots dippindots commented Dec 10, 2021

Fix cBioPortal/cbioportal#8920

Cause:

  • This happens when you select a study list that contains structural variant profiles, and then you use a custom sample list to select samples from studies that don’t contain structural variant profiles, then our frontend will try to fetch structural variants with an empty sample list. Then we will get an error because we sent an empty sample list.

Solution:

  • Do not fetch structural variants data when there are no applicable samples

Test:
https://deploy-preview-4089--cbioportalfrontend.netlify.app/results?plots_horz_selection=%7B%7D&plots_vert_selection=%7B%7D&plots_coloring_selection=%7B%7D&tab_index=tab_visualize&Action=Submit&session_id=6149d140e6ebe01a6ee32224

@dippindots dippindots self-assigned this Dec 10, 2021
@dippindots dippindots requested a review from alisman December 10, 2021 21:27
@alisman alisman merged commit 4872f7e into cBioPortal:master Dec 14, 2021
@dippindots dippindots added the bug label Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

query session not working
2 participants