appBootstrapper and routes .jsx->.tsx #4101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamabeshouse
force-pushed
the
9055-ts
branch
from
ee7f98b to
403d7aa
Compare
adamabeshouse
changed the title
alisman
reviewed
Dec 29, 2021
adamabeshouse
force-pushed
the
9055-ts
branch
from
403d7aa to
28810f0
Compare
alisman
reviewed
Jan 11, 2022
| @@ -443,7 +435,7 @@ export const makeRoutes = routing => { | |||
| component={ScrollToTop( | |||
| LocationValidationWrapper( | |||
| GroupComparisonPage, | |||
| comparisonTabParamValidator | |||
| comparisonTabParamValidator() | |||
There was a problem hiding this comment.
was this just not working before?
adamabeshouse
force-pushed
the
9055-ts
branch
from
28810f0 to
426abb1
Compare
Signed-off-by: Adam Abeshouse <abeshoua@mskcc.org>
adamabeshouse
force-pushed
the
9055-ts
branch
from
426abb1 to
2af5492
Compare
inodb
pushed a commit
that referenced
this pull request
Jan 18, 2022
appBootstrapper and routes .jsx->.tsx Former-commit-id: 8d79c325bb4d07d26bf23044b38bb27b1c335161
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cBioPortal/cbioportal#9055