Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally show NA when comparing categorical clinical data #4113

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

inodb
Copy link
Member

@inodb inodb commented Jan 5, 2022

Part of cBioPortal/icebox#407. Add NA toggle box on clinical comparison tab to show NA and NA like values

TODO:

  • make chart respond to checkbox change
  • include NA values (right now only showing 'unknown')
  • update screenshots

Screen Shot 2022-01-05 at 2 27 19 PM

@inodb inodb force-pushed the show-na-values-clinical-comparison branch from cfb273e to 102814d Compare January 6, 2022 14:58
@inodb inodb requested a review from alisman January 6, 2022 19:39
@inodb inodb force-pushed the show-na-values-clinical-comparison branch from 102814d to c5e1694 Compare January 6, 2022 20:00
Copy link
Collaborator

@alisman alisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved but with minor comments

@inodb inodb force-pushed the show-na-values-clinical-comparison branch from c5e1694 to b4e800e Compare January 7, 2022 10:46
Add checkbox to show NA and NA like values when making clinical
comparison. Note that the testing itself filters these values out on the
backend, so it only affects the visual representation in the charts.
@inodb inodb force-pushed the show-na-values-clinical-comparison branch from b4e800e to e1d2068 Compare January 7, 2022 10:51
@inodb inodb changed the title Show NA Values on clinical comparison tab Optionally show NA for categorical data on clinical comparison tab Jan 7, 2022
@inodb inodb changed the title Optionally show NA for categorical data on clinical comparison tab Optionally show NA when comparing categorical clinical data Jan 7, 2022
@inodb inodb merged commit a77e1f0 into cBioPortal:master Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants