Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly adjust oncokb content within annotation column #4121

Merged

Conversation

onursumer
Copy link
Member

Fix cBioPortal/cbioportal#9141

This is a workaround similar to the adjustment we have been doing for the column header. Ideally we should implement cBioPortal/icebox#192 so that we wouldn't need such workarounds.

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

@onursumer onursumer requested review from inodb, zhx828 and leexgh January 12, 2022 19:11
@onursumer onursumer force-pushed the oncokb-content-padding-workaround branch from e2a538e to 2b553e3 Compare January 14, 2022 14:47
@onursumer onursumer force-pushed the oncokb-content-padding-workaround branch 3 times, most recently from 1d175ea to 1ed6bed Compare January 18, 2022 19:28
@onursumer onursumer force-pushed the oncokb-content-padding-workaround branch from 1ed6bed to 513eb5e Compare January 19, 2022 11:59
@inodb inodb added the bug label Jan 19, 2022
@inodb inodb merged commit 43c9ae3 into cBioPortal:master Jan 19, 2022
@onursumer onursumer deleted the oncokb-content-padding-workaround branch January 24, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annotation column icon alignment is not always correct
4 participants