Putative Passenger tooltip icon (rebased) #4141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisman
approved these changes
Jan 25, 2022
|
@dianab0 in the oncoprint the mutation is a putative driver but in the tooltip it is a putative passenger - is that right? Or was this just for development? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a flash icon for the Putative Driver in the Oncoprint tooltip, but there is no icon for the Putative Passenger. I have added a gray circle icon for it as in the gif below.
Rebased to the new master and changed the img icon to svg circle as below:
Screenshot from 2022-01-17 15-06-42
PR is same as #4120 but rebased to new master.