Improve performance for generic assay selection in add charts workflow #4143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisman
reviewed
Jan 24, 2022
|
|
||
| export default class OptimizedOption extends React.Component<any> { | ||
| public render() { | ||
| delete this.props.innerProps.onMouseMove; |
There was a problem hiding this comment.
@alisman This is because the mouse move event and mouseover event will force the react select component to iterate the whole list of options, it will not impact loading speed, but when you move between options, you will notice significant lagging doing so.
And since these two events are not very important, we can just remove those to get a speedy response.
alisman
approved these changes
Jan 24, 2022
alisman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial Fix cBioPortal/cbioportal#9155
This will improve performance for generic assay selection in study view and oncoprint
Describe changes proposed in this pull request:
react-windowed-select: https://github.com/jacobworrel/react-windowed-select to improve select component performancemouseOverandmouseMoveevents to improve performance during selection.Testing:
Previous: link to current
New: link to pr preview
Select
Phosphosite Quantificationfor testing: