Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use variant class as well when generating the OncoKB query id #4196

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

onursumer
Copy link
Member

Fix cBioPortal/cbioportal#9309

This is a workaround. We may still end up with duplicate ids for other cases when the site 2 gene id is missing.

Archer_fusions_annotated

@onursumer onursumer requested review from inodb and zhx828 March 3, 2022 16:19
Copy link
Member

@zhx828 zhx828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@onursumer onursumer force-pushed the generate-query-sv-id-fix branch from 9a8c599 to f9f543c Compare March 4, 2022 14:23
@inodb inodb added the bug label Mar 4, 2022
@inodb inodb merged commit d5febda into cBioPortal:master Mar 4, 2022
@onursumer onursumer deleted the generate-query-sv-id-fix branch March 8, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oncogenic archer fusion is not counted in the SV/Fusion Driver category
3 participants