Don't fetch ndex status unless Pathways tab is active #4280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisman
commented
May 31, 2022
| hide={ | ||
| !getServerConfig().show_ndex || | ||
| !this.resultsViewPageStore | ||
| .remoteNdexUrl.isComplete || |
There was a problem hiding this comment.
problem was that this actually gets executed even though the component which is consuming it won't render. i.e. if you look at code around the tab, you will see that there is no condition which prevents this from getting executed. you could put a condition activeTab=pathways, and that would also solve this problem, but really, the fetch for ndex status should be nested inside the pathways component so that it the code won't be reached unless the pathways tab actually renders.
There was a problem hiding this comment.
Gotcha -thank you! That makes sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to wait until user navigates to the pathways tab before we call ndex service
Fixres cBioPortal/cbioportal#9569