Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve local db screenshot #4286

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Improve local db screenshot #4286

merged 1 commit into from
Jun 9, 2022

Conversation

dippindots
Copy link
Member

@dippindots dippindots commented Jun 7, 2022 •
edited
Loading

This will remove the background image and make sure this test only tests what it concerns.
image

@dippindots dippindots requested a review from alisman June 9, 2022 18:29
@dippindots dippindots self-assigned this Jun 9, 2022
@dippindots dippindots marked this pull request as ready for review June 9, 2022 18:29
inodb
inodb approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Group approval 🙌

@inodb inodb added the test label Jun 9, 2022
@inodb inodb merged commit bef7005 into cBioPortal:master Jun 9, 2022
@dippindots dippindots deleted the fix-local-e2e branch June 9, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inodb inodb inodb approved these changes

@alisman alisman Awaiting requested review from alisman

Assignees

@dippindots dippindots

Labels
ready to review test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dippindots @inodb