Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OncoKB Updates #4290

Merged
merged 2 commits into from
Jun 10, 2022
Merged

OncoKB Updates #4290

merged 2 commits into from
Jun 10, 2022

Conversation

zhx828
Copy link
Member

@zhx828 zhx828 commented Jun 10, 2022

  • Update oncokb-styles to use latest OncoKB logo
  • Remove OncoKB images from portal repo and use the ones in oncokb-styles
  • Add trademark to most of OncoKB text
  • Remove OncoKB Predicted Oncogenic concept

zhx828 added 2 commits June 10, 2022 10:49
Signed-off-by: Hongxin <jackson.zhang.828@gmail.com>
@zhx828 zhx828 requested review from alisman, onursumer and leexgh June 10, 2022 15:51
Copy link
Member

@onursumer onursumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Copy link
Member

@leexgh leexgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Would it be good to add trademark in download file as well?

@alisman alisman merged commit 73ec1aa into cBioPortal:master Jun 10, 2022
@zhx828 zhx828 added the oncokb label Jun 10, 2022
@zhx828 zhx828 deleted the update-oncokb-logo branch June 14, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants