Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 3d hotspots svg font family #4303

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Fix 3d hotspots svg font family #4303

merged 1 commit into from
Jun 16, 2022

Conversation

onursumer
Copy link
Member

@onursumer onursumer requested review from inodb and zhx828 June 16, 2022 16:20
zhx828
zhx828 approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@zhx828 zhx828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did that happen? 😂

@onursumer
Copy link
Member Author

@zhx828 apparently the new @rollup/plugin-image cannot handle malformed svg files. Also, looks like we have 2 copies of this image. I already fixed the other one in my previous PR (https://github.com/onursumer/cbioportal-frontend/blob/master/src/shared/components/annotation/images/3d-hotspots.svg?short_path=8b398df#L12), but missed this one.

@inodb inodb added the bug label Jun 16, 2022
@inodb inodb merged commit c5146cf into cBioPortal:master Jun 16, 2022
@onursumer onursumer deleted the fix-3d-hotspots-svg branch June 20, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhx828 zhx828 zhx828 approved these changes

@inodb inodb Awaiting requested review from inodb

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3D hotspot icon is not being rendered properly
3 participants
@onursumer @zhx828 @inodb