Display a detailed error message for invalid molecular profiles #4306
Conversation
…file ids in the filter
|
|
||
| if (invalidMolecularProfiles.length > 0) { | ||
| return Promise.reject({ | ||
| detailedErrorMessage: `Invalid molecular profile id(s): ${invalidMolecularProfiles.join( |
There was a problem hiding this comment.
Not sure if this is the best solution. detailedErrorMessage is a custom field. We may want to have a well defined Error object for consistency and always use the same fields everywere.
| <ErrorMessage /> | ||
| <ErrorMessage | ||
| message={detailedErrorMessages.join('\n')} | ||
| disableDefaultContactMessage={ |
There was a problem hiding this comment.
Should we still keep the default contact message Please let us know about this error and how you got here at...?
| return ( | ||
| <div className={styles.container}> | ||
| <div className={styles['items-container']}> | ||
| {this.items.map(this.makeItem)} | ||
| </div> | ||
| {_.some(this.items, i => getItemStatus(i) === 'error') && ( | ||
| <ErrorMessage /> | ||
| <ErrorMessage | ||
| message={detailedErrorMessages.join('\n')} |
There was a problem hiding this comment.
Joining with \n is practically the same as joining with any white space. If we really need to format multiple lines of messages I think we need to pass a component instead of a simple string. Since encountering multiple detailed error messages is a low chance event, maybe it's okay to keep it like this for now?
|
This is better. But I think we should try to just kind of abort the whole page when this happens. We've struggled with how to this. Basically we need to dispatch an error to global error handler. Let me play with it a bit. |
Fix cBioPortal/cbioportal#9629