Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node to 16.17.1 #4388

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 71 additions & 38 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,19 @@ defaults: &defaults
working_directory: /tmp/repo
docker:
# specify the version you desire here
- image: circleci/node:15.2.1-browsers
- image: circleci/node:16.13.1-browsers
resource_class: large

run_e2e_and_save_artifacts: &run_e2e_and_save_artifacts
steps:
# - run:
# name: "Install yarn at specific version"
# command:
# sudo npm install --global yarn@1.22.4
- attach_workspace:
at: /tmp/
- run:
name: "Upgrade yarn"
command: sudo npm install --global yarn@1.22.5 --force
- run:
name: "Spin up frontend over ssl if necessary and run end to end tests"
command: |
sudo apt-get install build-essential libcairo2-dev libpango1.0-dev libjpeg-dev libgif-dev librsvg2-dev & \
yarn serveDist & \
cd end-to-end-test && \
yarn install --frozen-lockfile && \
Expand Down Expand Up @@ -71,10 +69,10 @@ jobs:
install:
<<: *defaults
steps:
# - run:
# name: "Install yarn at specific version"
# command:
# sudo npm install --global yarn@1.22.4
- run:
name: "Upgrade yarn"
command: |
sudo npm install --global yarn@1.22.5 --force
- run:
name: "Show yarn and node versions"
command: |
Expand All @@ -90,7 +88,14 @@ jobs:
keys:
- v8-dependencies-plus-dist-{{ checksum "has_source_changed" }}
- v8-dependencies-{{ checksum "yarn.lock" }}
# Download and cache dependencies
# - run:
# name: Setup python libraries
# command: |
# pip3 install requests pyyaml
- run:
name: Install canvas deps [for screenshot comparison]
command: |
sudo apt-get install build-essential libcairo2-dev libpango1.0-dev libjpeg-dev libgif-dev librsvg2-dev
- run: yarn
- run: yarn buildModules
#- run:
Expand Down Expand Up @@ -124,6 +129,10 @@ jobs:
steps:
- attach_workspace:
at: /tmp/
- run:
name: "Upgrade yarn"
command: |
sudo npm install --global yarn@1.22.5 --force
# check that all api responses are still the same
- run: "bash src/test/check_api_sync.sh"

Expand All @@ -136,6 +145,10 @@ jobs:
# sudo npm install --global yarn@1.22.4
- attach_workspace:
at: /tmp/
- run:
name: "Upgrade yarn"
command: |
sudo npm install --global yarn@1.22.5 --force
# run tests!
- run:
command: "yarn run testMain"
Expand All @@ -158,6 +171,10 @@ jobs:
# sudo npm install --global yarn@1.22.4
- attach_workspace:
at: /tmp/
- run:
name: "Upgrade yarn"
command: |
sudo npm install --global yarn@1.22.5 --force
# run tests!
- run:
command: "yarn run testPackagesCI"
Expand All @@ -174,6 +191,10 @@ jobs:
steps:
- attach_workspace:
at: /tmp/
- run:
name: "Upgrade yarn"
command: |
sudo npm install --global yarn@1.22.5 --force
# check that no `.only` statements are still in the tests
# Ignore doTest.only in oql parser
- run:
Expand All @@ -185,6 +206,10 @@ jobs:
steps:
- attach_workspace:
at: /tmp/
- run:
name: "Upgrade yarn"
command: |
sudo npm install --global yarn@1.22.5 --force
# make sure that there are no relative/incorrect package imports
- run:
name: "Check Incorrect Package Import Statements"
Expand Down Expand Up @@ -217,6 +242,10 @@ jobs:
- attach_workspace:
at: /tmp/
# - run:
# name: "Upgrade yarn"
# command: |
# sudo npm install --global yarn@1.22.5 --force
# - run:
# # needed to get python3 on the path (https://discuss.circleci.com/t/pyenv-pyvenv-command-not-found/4087/2)
# name: Add python3 to path [corrects bug in circle ci image and may be removed in the future]
# command: pyenv local 3.6.5 && virtualenv venv
Expand Down Expand Up @@ -349,6 +378,10 @@ jobs:
steps:
- attach_workspace:
at: /tmp/
- run:
name: "Upgrade yarn"
command: |
sudo npm install --global yarn@1.22.5 --force
- run:
name: 'Check code style with Prettier'
command: cd /tmp/repo/ && yarn run prettierCheckCircleCI
Expand All @@ -358,36 +391,36 @@ workflows:
install_and_test:
jobs:
- install
- prettier:
requires:
- install
filters:
branches:
ignore:
- master
- release-*
- rc
- unit_tests_main:
requires:
- install
- unit_tests_packages:
requires:
- install
# - prettier:
# requires:
# - install
# filters:
# branches:
# ignore:
# - master
# - release-*
# - rc
# - unit_tests_main:
# requires:
# - install
# - unit_tests_packages:
# requires:
# - install
- end_to_end_tests:
requires:
- install
- end_to_end_tests_localdb:
requires:
- install
- api_sync:
requires:
- install
- check_forgotten_spec_only_statements:
requires:
- install
- check_incorrect_import_statements:
requires:
- install
# - end_to_end_tests_localdb:
# requires:
# - install
# - api_sync:
# requires:
# - install
# - check_forgotten_spec_only_statements:
# requires:
# - install
# - check_incorrect_import_statements:
# requires:
# - install
nightly:
triggers:
- schedule:
Expand Down
7 changes: 7 additions & 0 deletions end-to-end-test/index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<html>
<head>
<script>
window.location.href = "/shared/imageCompare.html"
</script>
</head>
</html>
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM circleci/node:15.2.1-browsers
FROM circleci/node:16.13.1-browsers
MAINTAINER Pim van Nierop <pim@thehyve.nl>

LABEL Description="End-2-end test image for cBioPortal frontend"
Expand All @@ -8,4 +8,6 @@ LABEL Description="End-2-end test image for cBioPortal frontend"

USER root

RUN sudo npm install --global yarn@1.22.5 --force

CMD /cbioportal-frontend/end-to-end-test/local/docker_compose/docker/screenshottest.sh
17 changes: 10 additions & 7 deletions end-to-end-test/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,27 +15,30 @@
"author": "",
"license": "AGPL-3.0-or-later",
"dependencies": {
"@wdio/cli": "^6.10.5",
"@wdio/allure-reporter": "7",
"@wdio/cli": "7",
"@wdio/codemod": "^0.12.0",
"@wdio/junit-reporter": "^6.11.0",
"browserstack-local": "1.3.0",
"canvas": "^2.6.1",
"clipboardy": "^2.0.0",
"fs-extra": "^9.0.1",
"jscodeshift": "^0.14.0",
"node-ipc": "^9.1.3",
"wdio-browserstack-service": "0.1.4",
"wdio-errorshot-reporter": "^0.2.1",
"wdio-image-comparison-service": "^2.0.0",
"wdio-junit-reporter": "^0.3.1",
"wdio-novus-visual-regression-service": "^1.2.4",
"wdio-spec-reporter": "0.1.0"
"wdio-novus-visual-regression-service": "1.2.5",
"wdio-spec-reporter": "0.1.0",
"webdriverio": "7"
},
"devDependencies": {
"@wdio/local-runner": "^6.10.5",
"@wdio/local-runner": "7",
"@wdio/mocha-framework": "^6.10.4",
"@wdio/spec-reporter": "^6.8.1",
"@wdio/sync": "^6.10.4",
"@wdio/spec-reporter": "7",
"chromedriver": "^87.0.1",
"wdio-chromedriver-service": "^6.0.4",
"wdio-chromedriver-service": "7",
"wdio-json-reporter": "^2.0.0"
}
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading