-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show reference genome in study list #4407
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BasLee I think the pills are a little too eye grabbing for highlighting a technical detail. The publication icon and study view icon should prolly be more prominent compared to the reference genome info. There are also a lot of other properties that might be more interesting features of a study too highlight (e.g. does it have mrna, timeline data, etc). Wondering if it's essential to show this when arriving on the homepage? One option is to e.g. show the reference genome in the front (so the text doesn't move) after you are accidentally combining some that shouldn't be combined?
@pvannierop @Sjoerd-van-Hagen adding you guys to this discussion. see comment above |
@inodb I think these badges are more than technical details. It is an indicator to the user whether certain studies can be selected together for integrated analysis. IOW it drives user interaction. |
65bd108
to
3a9b5b0
Compare
@inodb @pvannierop @alisman the status of this new feature is a bit uncertain at the moment, maybe we can shelve it for the moment? |
@BasLee Lets try to not use an icon but show inline text like so:
|
@pvannierop Fixed in bc06f45 |
5571650
to
56ee287
Compare
To assist the user in selecting compatible studies, the study list now shows a
badgetext of the used reference genome. It is only shown when a cbioportal instance uses multiple reference genomes.Dummy study list to illustrate label
Changes:
Label that shows used reference genome (when multiple reference genomes are available)
Label is disabled by default using property
skin_home_page_show_reference_genome
(backend property can be added in the future).