Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show reference genome in study list #4407

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Conversation

BasLee
Copy link

@BasLee BasLee commented Nov 2, 2022

To assist the user in selecting compatible studies, the study list now shows a badge text of the used reference genome. It is only shown when a cbioportal instance uses multiple reference genomes.

Screenshot from 2023-02-01 15-46-20
Dummy study list to illustrate label

Changes:

  • Label that shows used reference genome (when multiple reference genomes are available)

  • Label is disabled by default using property skin_home_page_show_reference_genome (backend property can be added in the future).

@BasLee BasLee changed the title Show reference genome tag in study list Show reference genome badge in study list Nov 2, 2022
src/shared/constants.ts Outdated Show resolved Hide resolved
Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BasLee I think the pills are a little too eye grabbing for highlighting a technical detail. The publication icon and study view icon should prolly be more prominent compared to the reference genome info. There are also a lot of other properties that might be more interesting features of a study too highlight (e.g. does it have mrna, timeline data, etc). Wondering if it's essential to show this when arriving on the homepage? One option is to e.g. show the reference genome in the front (so the text doesn't move) after you are accidentally combining some that shouldn't be combined?

@alisman
Copy link
Collaborator

alisman commented Nov 4, 2022

@pvannierop @Sjoerd-van-Hagen adding you guys to this discussion. see comment above

@pvannierop
Copy link
Contributor

@inodb I think these badges are more than technical details. It is an indicator to the user whether certain studies can be selected together for integrated analysis. IOW it drives user interaction.

@BasLee BasLee force-pushed the ref-gen-badge branch 2 times, most recently from 65bd108 to 3a9b5b0 Compare November 7, 2022 14:01
@BasLee
Copy link
Author

BasLee commented Nov 14, 2022

@inodb @pvannierop @alisman the status of this new feature is a bit uncertain at the moment, maybe we can shelve it for the moment?

@pvannierop
Copy link
Contributor

@BasLee Lets try to not use an icon but show inline text like so:

123434 samples | hg18 <rest of icons>

@BasLee
Copy link
Author

BasLee commented Feb 1, 2023

@BasLee Lets try to not use an icon but show inline text like so: [..]

@pvannierop Fixed in bc06f45

@BasLee
Copy link
Author

BasLee commented Feb 1, 2023

@BasLee I think the pills are a little too eye grabbing for highlighting a technical detail. [..]

@inodb Fixed in bc06f45: the badge is replaced with a less intrusive text 'label'

@BasLee BasLee requested review from alisman and inodb February 1, 2023 14:55
@BasLee BasLee changed the title Show reference genome badge in study list Show reference genome in study list Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants