Only allow expression profiles from tcga pancan in plots tab #4409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onursumer
reviewed
Nov 4, 2022
| } else { | ||
| return profiles.filter( | ||
| p => | ||
| p.molecularAlterationType != |
There was a problem hiding this comment.
Is != on purpose?
Suggested change
| p.molecularAlterationType != | |
| p.molecularAlterationType !== |
inodb
changed the title
alisman
force-pushed
the
noExpression
branch
2 times, most recently
from
2cba915 to
e368d1b
Compare
alisman
commented
Nov 11, 2022
| return profiles.filter( | ||
| p => | ||
| 
onursumer
reviewed
Nov 11, 2022
| AlterationTypeConstants.MICRO_RNA_EXPRESSION, | ||
| AlterationTypeConstants.PROTEIN_LEVEL, | ||
| AlterationTypeConstants.RNA_EXPRESSION, | ||
| AlterationTypeConstants.MICRO_RNA_EXPRESSION, |
There was a problem hiding this comment.
the last AlterationTypeConstants.MICRO_RNA_EXPRESSION is duplicate
alisman
force-pushed
the
noExpression
branch
from
e368d1b to
76b940e
Compare
Co-authored-by: Onur Sumer <s.onur.sumer@gmail.com>
dippindots
pushed a commit
to dippindots/cbioportal-frontend
that referenced
this pull request
Feb 21, 2023
…tal#4409) * Do not allow expression profiles in results view unless studies are "comparable" * Fix if/else condition Co-authored-by: Onur Sumer <s.onur.sumer@gmail.com> Co-authored-by: Onur Sumer <s.onur.sumer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter out expression profiles when rule for sharing profiles is not met. This is for multi-study queries in which expression data is not normalized and shouldn't be compared (unless part of same group)