Add message when no available mutations and tabs for top ten genes with highest frequency for group comparison lollipop plot #4415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisman
reviewed
Nov 11, 2022
alisman
reviewed
Nov 11, 2022
| @@ -45,22 +69,65 @@ export default class GroupComparisonMutationsTab extends React.Component< | |||
| </div> | |||
| ); | |||
| } | |||
|
|
|||
| let activeTabId; | |||
There was a problem hiding this comment.
i would think this logic should be in a computed getter activeTab
alisman
reviewed
Nov 11, 2022
gblaih
force-pushed
the
group-comparison-lollipop-plot
branch
3 times, most recently
from
c5e3ff5 to
2b02719
Compare
… for selected gene, fixed gene tab and selector inconsistency issues, removed gene alerts
alisman
force-pushed
the
group-comparison-lollipop-plot
branch
from
2b02719 to
d8e5d86
Compare
dippindots
pushed a commit
to dippindots/cbioportal-frontend
that referenced
this pull request
Feb 21, 2023
… for selected gene, fixed gene tab and selector inconsistency issues, removed gene alerts (cBioPortal#4415) Co-authored-by: Bryan Lai <laib1@mskcc.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue cBioPortal/cbioportal#9888
Follow up to #4392