Add error alert type for non-catastrophic errors #4428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisman
force-pushed
the
oncokb-error
branch
from
c86e113 to
1ce8aac
Compare
alisman
force-pushed
the
oncokb-error
branch
from
1ce8aac to
ce7b1e1
Compare
onursumer
approved these changes
Dec 16, 2022
src/appShell/App/Container.tsx
Outdated
| render() { | ||
| if (this.state.hasError) { | ||
| // You can render any custom fallback UI | ||
| console.log(this.state.error); |
There was a problem hiding this comment.
Is this console.log on purpose?
alisman
force-pushed
the
oncokb-error
branch
4 times, most recently
from
66e7f03 to
89c7c1a
Compare
…s and alerts. Add error boundary for js errors
alisman
force-pushed
the
oncokb-error
branch
from
7623e00 to
7cd61e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to fail gracefully when oncock or GN services fail, allowing user to use the site but with knowledge that annotation is broken.
