Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gene panel column download in patient view page #4430

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

dippindots
Copy link
Member

@dippindots dippindots commented Nov 23, 2022

Fix cBioPortal/cbioportal#8944

Describe changes proposed in this pull request:
This pr fixes the gene panel column download in patient view page, this issue is caused by the gene panel column tried to provide array data to lazyMobxTable download function. But the array size is not compatible with requirement. So I changed download object from a array to a string by joining the array element.

Testing:

  1. Go to https://cbioportal.mskcc.org/patient?studyId=mixed_cbe_kunga_AK_pedpdx&caseId=p_C_000733
  2. Click Download TSV on Mutations table

@dippindots dippindots self-assigned this Nov 23, 2022
@dippindots dippindots requested a review from alisman November 23, 2022 14:21
@dippindots dippindots added the bug label Nov 23, 2022
@alisman alisman merged commit 2e7d3ac into cBioPortal:master Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

downloading of mutations table not working for specific case
2 participants