Fix incorrect mutation frequency in group comparison lollipop plot #4432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisman
reviewed
Nov 30, 2022
| 100 | ||
| : countUniqueMutations(mutations); | ||
| } | ||
|
|
||
| @action.bound | ||
| private onScaleToggle(selectedScale: AxisScale) { | ||
| this.props.urlWrapper.updateURL({ |
There was a problem hiding this comment.
if we we are updaing the url then we shouldn't need to also need the local (this.axisMode). That hsould instead be derived from the url
alisman
reviewed
Nov 30, 2022
alisman
reviewed
Nov 30, 2022
| [groupUid: string]: Sample[]; | ||
| } = {}; | ||
| for (const group of groups) { | ||
| for (const studyObject of group.studies) { |
|
@gblaih the frequency fix should be in it's own PR |
gblaih
force-pushed
the
group-comparison-lollipop-plot-frequency
branch
from
33872dd to
dae988c
Compare
gblaih
changed the title
alisman
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue in cBioPortal/cbioportal#9901