Capture selected scale in URL in group comparison lollipop plot #4436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gblaih
force-pushed
the
group-comparison-lollipop-plot-scale-url
branch
from
334f741 to
55efa03
Compare
gblaih
force-pushed
the
group-comparison-lollipop-plot-scale-url
branch
from
a3306c1 to
e9d6696
Compare
gblaih
force-pushed
the
group-comparison-lollipop-plot-scale-url
branch
from
e9d6696 to
b58c35b
Compare
alisman
reviewed
Dec 2, 2022
| @@ -132,6 +132,7 @@ export default class GroupComparisonMutationsTab extends React.Component< | |||
| </div> | |||
| <GroupComparisonMutationsTabPlot | |||
| store={this.props.store} | |||
| urlWrapper={this.props.urlWrapper} | |||
There was a problem hiding this comment.
it would be better to give this component a property onScaleToggle and then update the urlWrapper at this level.
There was a problem hiding this comment.
fixed, gave component onScaleToggle
alisman
reviewed
Dec 2, 2022
| @@ -130,7 +132,11 @@ export default class GroupComparisonMutationsTabPlot extends React.Component< | |||
| plotLollipopTooltipCountInfo={ | |||
| plotLollipopTooltipCountInfo | |||
| } | |||
| axisMode={this.axisMode} | |||
| axisMode={ | |||
There was a problem hiding this comment.
again, just give the component an axisMode property and keep it agnostic to the url, which is really a concert of the page component
gblaih
force-pushed
the
group-comparison-lollipop-plot-scale-url
branch
from
a6fcd70 to
f21eef6
Compare
gblaih
force-pushed
the
group-comparison-lollipop-plot-scale-url
branch
from
f21eef6 to
32b8665
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue in cBioPortal/cbioportal#9901