Default axis scale to frequency in group comparison lollipop plot #4442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisman
reviewed
Dec 5, 2022
| @@ -124,7 +124,10 @@ export default class GroupComparisonMutationsTabPlot extends React.Component< | |||
| plotLollipopTooltipCountInfo={ | |||
| plotLollipopTooltipCountInfo | |||
| } | |||
| axisMode={this.props.store.userSelectedAxisMode} | |||
| axisMode={ | |||
| this.props.store.userSelectedAxisMode || | |||
There was a problem hiding this comment.
sorry to be annoying but i think we should probably put this default inside of the the userSelectedAxisMode.
And also, I think we can just call it axisMode since I don't think we strongly need to distinguish it from a default or something else.
alisman
approved these changes
Dec 5, 2022
alisman
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue when there is no selected axis scale. When there is no selected axis scale, it should default to frequency mode.